Skip to content

Conversation

kirti763
Copy link
Contributor

@kirti763 kirti763 commented Aug 1, 2025

Notes for Reviewers

This PR fixes #726

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit f66421e
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/68a32408327aa20008d6dc80
😎 Deploy Preview https://deploy-preview-731--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vr-varad
Copy link
Contributor

vr-varad commented Aug 4, 2025

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kirti763, thanks for this.

Would it be possible to convert this section into a collapsible section? Since these are specific issues that not all users will face, I think presenting them this way would lead to a cleaner and more streamlined user experience.

Additionally, I believe the current location (/extending-the-academy) isn't the most appropriate. Placing this information in the FAQ section of creating-your-learning-path would be a better fit. What do you think?

@kirti763
Copy link
Contributor Author

Totally agree with you, @zihanKuang
I've moved the section as suggested

Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kirti763, there's a merge conflict.
The FAQ format in academy/creating-your-learning-path/index.md has been updated, so you'll need to update your branch.

Signed-off-by: kirti763 <kg4180553@gmail.com>
Signed-off-by: kirti763 <kg4180553@gmail.com>
@kirti763 kirti763 force-pushed the add-debug-events-doc branch from 638e932 to f5d7384 Compare August 18, 2025 11:13
@kirti763
Copy link
Contributor Author

done, @zihanKuang

@zihanKuang
Copy link
Contributor

zihanKuang commented Aug 18, 2025

done, @zihanKuang

@kirti763 Did you accidentally copy an extra file?👀

@zihanKuang zihanKuang merged commit 4dd4f93 into layer5io:master Aug 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Academy: Enhancing academy contributor docs with debug events
3 participants